Update dag list default sorting to alphabetically#50600
Update dag list default sorting to alphabetically#50600pierrejeambrun merged 1 commit intoapache:mainfrom
Conversation
I don't have a strong opinion, but using |
|
We can go for |
Dissmissing my review since there might be a better place for this fix as Pierre mentioned
Yep, |
Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
fb846e7 to
1a22f67
Compare
|
Thanks for pointing out. I've updated to use |
|
Is it perhaps better to make it configurable somewhere what you want to sort by? Different people might have different preferences of what to sort by. |
|
It should be topological, falling back to the order it is added to the dag. There is an existing bug for this |
|
Sorry, totally misread this and thought it was about tasks |
|
Make sense to make a config. I would try to implement it. Thanks! |
|
Different people may want different sort order in the same instance too though. Maybe the sort choice should be sticky when you navigate away and back, instead of a global config. |
|
Yeah, that makes sense. We do that for a bunch of stuff already with graph view, etc. We can do the same thing here as well. |
pierrejeambrun
left a comment
There was a problem hiding this comment.
LGTM, we can add follow up PR to persist the sorting preference in the localstorage.
|
Sure, I would open following PR for that. Thanks. |
(cherry picked from commit ae9ae04) Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com> Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
Why
Currently the default dag list sorting isn’t by dag_display_name which is not really straightforward
How
Update the default sorting to alphabetically.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.